Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in RenderingServer docs #96975

Merged

Conversation

Kiisu-Master
Copy link
Contributor

RenderingServer.viewport_get_measured_render_time_gpu was self referencing itself in a "See also" sentence.
I believe it meant to reference the similar function for cpu instead.

@Kiisu-Master Kiisu-Master requested a review from a team as a code owner September 13, 2024 19:05
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Usually the "see also" points to the scene-level version of the function (i.e. the Viewport method in this case). But Viewport doesn't expose this, so the intention must have been to highlight the CPU variant.

@clayjohn clayjohn added this to the 4.4 milestone Sep 13, 2024
@clayjohn clayjohn added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 13, 2024
@akien-mga akien-mga merged commit 903f15d into godotengine:master Sep 16, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation enhancement topic:rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants