Ignore --test flag when it is an user-provided argument
#96926
Conversation
Dowsley
force-pushed
the
user-provided-arguments-fix
branch
2 times, most recently
from
d202dcc to
f03a54b
Compare
AThousandShips
added
bug
topic:core
regression
cherrypick:4.2
|
Looks good to me, please squash the commits together so we can merge this. See PR workflow for instructions 🙂 |
Dowsley
force-pushed
the
user-provided-arguments-fix
branch
from
d1254e1 to
d481669
Compare
Since the change was so small I made it again but on top of current master. Then force pushed it here. Is that enough? |
akien-mga
changed the title
--test flag when it is an user-provided argument
| // Early return to ignore a possible user-provided "--test" argument. | ||
| if ((strlen(argv[x]) == 2) && ((strncmp(argv[x], "--", 2) == 0) || (strncmp(argv[x], "++", 2) == 0))) { | ||
| tests_need_run = false; | ||
| return EXIT_SUCCESS; | ||
| } |
There was a problem hiding this comment.
Wouldn't this make godot --test -- --yolo fail to run tests?
There was a problem hiding this comment.
I guess not, this will process in order so --test would be seen and handled first.
There was a problem hiding this comment.
Exactly. But I agree that this is hacky and we should look for an alternative way to handle this.
Won't #90507 be missed though?
There was a problem hiding this comment.
I'm not sure how to make it better, in the end I concluded that it's probably good enough for now.
|
This is getting somewhat hacky for a niche use case, I might be more in favor of reverting #90507 if this has such implications. |
|
Thanks! |
Simple fix for edge-case #95922