Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore --test flag when it is an user-provided argument #96926

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Dowsley
Copy link
Contributor

@Dowsley Dowsley commented Sep 12, 2024

Simple fix for edge-case #95922

@Dowsley Dowsley requested a review from a team as a code owner September 12, 2024 17:55
@Dowsley Dowsley force-pushed the user-provided-arguments-fix branch from efcdf60 to d202dcc Compare September 12, 2024 17:56
@Dowsley Dowsley force-pushed the user-provided-arguments-fix branch from d202dcc to f03a54b Compare September 12, 2024 17:58
@AThousandShips AThousandShips added bug topic:core regression cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Sep 12, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Sep 12, 2024
main/main.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master 77d6283), it works as expected.

Should be good to merge after applying suggestions.

Co-authored-by: Hugo Locurcio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release regression topic:core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants