Avoid expensive sqrt operation in hot loop of BitMap.grow_mask
#96885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Sep 12, 2024
LuizZak
force-pushed
the
grow_mask_sqrt_fix
branch
from
390553b to
293cc21
Compare
|
I may have come up with a better solution involving an intermediary |
akien-mga
changed the title
BitMap.grow_mask
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that
BitMap.grow_maskcould be quite slow for large radii on large images, and while looking for ways to optimize the process I noticed that the operation performs adistance_tothat could be converted into adistance_squared_to, avoiding asqrtfrom being performed on every pixel, multiple times.Guidance is requested on perhaps how to ensure this doesn't lead to an unwanted regression on pixels on the edge of expanded bitmaps.