Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Add .editorconfig to the projects. #96845

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 11, 2024

Adds .editorconfig to ensure external editors/IDEs use UTF-8 encoding.

Fixes #27083
Supersede #96837

@bruvzg bruvzg added this to the 4.4 milestone Sep 11, 2024
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this will add a .editorconfig into existing projects. In the event that this is desired only for new projects, this code could be moved to editor/project_manager/project_dialog.cpp inside ProjectDialog::ok_pressed(). However, I am not against retroactively adding this file personally, I'm all for it 👍

@bruvzg
Copy link
Member Author

bruvzg commented Sep 11, 2024

Note that this will add a .editorconfig into existing projects.

It this case, it's better to add it to the existing projects, Godot always used exclusively UTF-8, so it should not be an issue. And you can edit the file if you want different config (it won't overwrite existing one).

@akien-mga akien-mga merged commit 4788f54 into godotengine:master Sep 11, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga changed the title [Editor] Add .editorconfig to the projects. [Editor] Add .editorconfig to the projects. Sep 11, 2024
@AThousandShips
Copy link
Member

AThousandShips commented Sep 11, 2024

This injects .editorconfig in modules/gdscript/tests/scripts/ when running tests but it isn't ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants