Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement instance uniforms in Compatibility renderer #96819

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Sep 10, 2024

Cherrypicked from: #96814

The infrastructure for this has been in place for a long time, just the final details were needed to make it work.

@clayjohn
Copy link
Member Author

@akien-mga This is a really trivial PR, we can probably go ahead with it without getting a rendering team approval.

@mhilbrunner
Copy link
Member

mhilbrunner commented Oct 5, 2024

✔️ Code looks fine
✔️ Style looks fine
✔️ Tested: Builds, runs, and feature works fine on Windows, behold:

image

With this, I can now switch between Compatibility and Forward+ and this scene works in both.

Docs are here: https://docs.godotengine.org/en/stable/tutorials/shaders/shader_reference/shading_language.html#per-instance-uniforms

@clayjohn clayjohn merged commit 842f982 into godotengine:master Oct 7, 2024
20 checks passed
@clayjohn clayjohn deleted the GLES3-instance-uniforms branch October 7, 2024 19:41
@JekSun97
Copy link
Contributor

JekSun97 commented Oct 8, 2024

Thanks!

@ClintochX
Copy link

Thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:rendering topic:shaders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add instance shader uniforms support/fallback in Compatibility renderer
5 participants