Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Use toast (notification) instead of dialog when saving with no open scene #96773

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

tetrapod00
Copy link
Contributor

@tetrapod00 tetrapod00 commented Sep 10, 2024

When saving (ctrl+s) with no open scene, such as when editing shaders, an dialog popup appears. This does not need to be a popup that requires a click to close. Instead, we can use the editor toaster. The information is still displayed, but no longer interrupts the flow of work.

Before:
Godot_v4 3-stable_win64_XwZ7TVfRVi

After:
godot windows editor dev x86_64_1fENl6cLB5

I might argue that it's not even correct for any message to appear when saving in this case. Files saving when you save is expected behavior. Saving scripts or scenes (even multiple at once) does not send any message to the console, the undo log, dialog popup, or toast. If a scene is open, then saving the same resources saved in this case is done silently. All signs point to this message being unnecessary.

But that change may require some discussion, since it's trying to match the current save behavior in other contexts.

@tetrapod00
Copy link
Contributor Author

The other case of saving as a scene with no root node should remain a popup, in my opinion, as it requires an action from the user:
image

@tetrapod00 tetrapod00 requested a review from a team as a code owner November 10, 2024 22:49
@Repiteo Repiteo merged commit bfc1d2f into godotengine:master Dec 10, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Dec 10, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants