Update AnimationPlayer in real-time when bezier curve properties or bezier editor changes

[Dowsley]

• Fixes AnimationPlayer doesn't update in real-time when bezier curves change #96591

I am unsure whether I should add the update to AnimationBezierTrackEdit::duplicate_selected_key as well.

[SaracenOne]

I would consider adding an update in _change_selected_keys_handle_mode too since right-clicking and changing the handle mode currently does not trigger an update of the property.

[SaracenOne]

I would also say that it is probably worth adding the update to the duplicate operation for good measure.

[Dowsley]

I would consider adding an update in _change_selected_keys_handle_mode too since right-clicking and changing the handle mode currently does not trigger an update of the property.

I would also say that it is probably worth adding the update to the duplicate operation for good measure.

Updated with the required changes. I suppose the EditorUndoRedoManager is a queue, so the order of add calls matter. So I put the APE's update key frame adds above the queue_redraw adds.

[SaracenOne]

Actually, found two more instances where we would also want to trigger the update: cutting and pasting.

To fix pasting, I think you should change line 1923 from:

		undo_redo->commit_action();

		queue_redraw();

to:

		AnimationPlayerEditor *ape = AnimationPlayerEditor::get_singleton();
		if (ape) {
			undo_redo->add_do_method(ape, "_animation_update_key_frame");
			undo_redo->add_undo_method(ape, "_animation_update_key_frame");
		}
		undo_redo->add_do_method(this, "queue_redraw");
		undo_redo->add_undo_method(this, "queue_redraw");

		undo_redo->commit_action();

For cutting, add this below line 1845:

		AnimationPlayerEditor *ape = AnimationPlayerEditor::get_singleton();
		if (ape) {
			undo_redo->add_do_method(ape, "_animation_update_key_frame");
			undo_redo->add_undo_method(ape, "_animation_update_key_frame");
		}
		undo_redo->add_do_method(this, "queue_redraw");
		undo_redo->add_undo_method(this, "queue_redraw");

This should solve the remaining edge cases.

[Dowsley]

@SaracenOne good catch. Force pushed the changes.

[SaracenOne]

LGTM 👍

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[Zireael07]

This was someone's first contribution? O_o

[Dowsley]

It was mostly copying and pasting 😆 thanks for the help folks

[akien-mga]

Cherry-picked for 4.3.1.