Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some android editor settings by default on XR devices #96697

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

devloglogan
Copy link
Contributor

Some touchscreen related editor settings enabled by default in the android editor aren't needed on XR devices, namely enable_long_press_as_right_click and increase_scrollbar_touch_area. This PR has those settings default to false on XR devices for better UX.

@devloglogan
Copy link
Contributor Author

@m4gr3d with the supportsFeature() override in BaseGodotEditor, I'm wondering if we should move the hasPiPSystemFeature() into the same function.

@m4gr3d
Copy link
Contributor

m4gr3d commented Sep 8, 2024

@m4gr3d with the supportsFeature() override in BaseGodotEditor, I'm wondering if we should move the hasPiPSystemFeature() into the same function.

@devloglogan PiP is a system specific feature defined in https://developer.android.com/reference/android/content/pm/PackageManager#FEATURE_PICTURE_IN_PICTURE, not a Godot one.
I can see how the two can be confused, and for clarity we may want to rename GodotHost#supportsFeature(...) to GodotHost#supportsGodotFeature(...).

@m4gr3d
Copy link
Contributor

m4gr3d commented Sep 8, 2024

I can see how the two can be confused, and for clarity we may want to rename GodotHost#supportsFeature(...) to GodotHost#supportsGodotFeature(...).

On further reflection, I'm thinking about leaving the name as is in order to match the terminology used in GodotPlugin, but we should update the javadocs to clarify the method refers to a Godot feature.

Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just test the latest version of this on Quest 3 - it's working great!

@devloglogan
Copy link
Contributor Author

devloglogan commented Sep 9, 2024

@akien-mga thanks for catching those, fixed!

@akien-mga akien-mga merged commit 07c3951 into godotengine:master Sep 9, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants