-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable some android editor settings by default on XR devices #96697
Conversation
platform/android/java/editor/src/meta/java/org/godotengine/editor/GodotEditor.kt
Outdated
Show resolved
Hide resolved
526747e
to
c6f61f2
Compare
@m4gr3d with the |
@devloglogan PiP is a system specific feature defined in https://developer.android.com/reference/android/content/pm/PackageManager#FEATURE_PICTURE_IN_PICTURE, not a Godot one. |
On further reflection, I'm thinking about leaving the name as is in order to match the terminology used in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just test the latest version of this on Quest 3 - it's working great!
platform/android/java/lib/src/org/godotengine/godot/GodotHost.java
Outdated
Show resolved
Hide resolved
c6f61f2
to
16e1d8a
Compare
@akien-mga thanks for catching those, fixed! |
Thanks! |
Some touchscreen related editor settings enabled by default in the android editor aren't needed on XR devices, namely
enable_long_press_as_right_click
andincrease_scrollbar_touch_area
. This PR has those settings default to false on XR devices for better UX.