Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Path3D editor #96651

Merged
merged 1 commit into from
Sep 8, 2024
Merged

Cleanup Path3D editor #96651

merged 1 commit into from
Sep 8, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 6, 2024

Resolves some TODO/FIXME comments and cleans up the code overall.

@KoBeWi KoBeWi added this to the 4.x milestone Sep 6, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner September 6, 2024 14:02
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Sep 6, 2024
@akien-mga
Copy link
Member

Needs rebase.

fire
fire approved these changes Sep 7, 2024
View reviewed changes
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed the code and didn't see anything worse.

@akien-mga akien-mga merged commit 4d42b22 into godotengine:master Sep 8, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the path_sweeping branch September 8, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@kleonc kleonc kleonc approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle topic:editor topic:3d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@KoBeWi @akien-mga @fire @kleonc