Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FileSystem Dock] Add symlink indicator and tooltip. #96643

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 6, 2024

Adds symlink arrow indicator and tooltip with link source.

Screenshot 2024-09-06 at 11 00 01

See #96603 (review)

@bruvzg bruvzg added this to the 4.x milestone Sep 6, 2024
@passivestar
Copy link
Contributor

Idea for another PR: Create symlinks instead of copying if you hold Alt+Ctrl/Cmd when dropping files onto the dock

@bruvzg
Copy link
Member Author

bruvzg commented Sep 6, 2024

Idea for another PR: Create symlinks instead of copying if you hold Alt+Ctrl/Cmd when dropping files onto the dock

Won't work on Windows, making symlinks still require admin permissions (or enabled developer mode).

@bruvzg bruvzg marked this pull request as ready for review September 9, 2024 07:06
@bruvzg bruvzg requested review from a team as code owners September 9, 2024 07:06
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Sep 12, 2024
@akien-mga akien-mga merged commit cc52112 into godotengine:master Sep 12, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Hilderin
Copy link
Contributor

Hilderin commented Sep 12, 2024

I have some concerns about this PR because it adds a check directly on disk for each directory and file everytime the FileSystemDock tree is recreated which is quite often. That will slow down considerably the tree update with large projects. It's already very slow for project with couple of thousand file (like 2-5sec). With a roundtrip to the disk, that will probably be catastrophic. In my opinion, the link information should have been added in the EditorFileSystem file tree and read while scanning and updated based on the last modified time like the other path and file properties. I did not do testing to prove my concern. I'll be glad to test it further and implement it if you wish.

@akien-mga
Copy link
Member

Yeah that's a very good point, would be worth testing further to confirm the performance impact and how to improve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants