Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy/paste options to preview material parameters in visual shader #96618

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Sep 5, 2024

This PR adds a menu button with two options to copy/paste parameters to/from the selected ShaderMaterial.

vs_preview_copypaste

This should help users to easily setup a required effects from parameters.

@Chaosus Chaosus requested a review from a team as a code owner September 5, 2024 17:44
@Chaosus Chaosus added this to the 4.4 milestone Sep 5, 2024
@Chaosus Chaosus force-pushed the vs_copy_paste_preview_material branch 2 times, most recently from 646e8f1 to b7c856f Compare September 6, 2024 12:09
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Needs rebase.

@Chaosus Chaosus force-pushed the vs_copy_paste_preview_material branch from b7c856f to b46a38e Compare November 12, 2024 17:15
@Chaosus
Copy link
Member Author

Chaosus commented Nov 12, 2024

Needs rebase.

Done

@Chaosus Chaosus force-pushed the vs_copy_paste_preview_material branch from b46a38e to 1a10daa Compare November 12, 2024 18:31
@Chaosus Chaosus force-pushed the vs_copy_paste_preview_material branch from 1a10daa to 485e7f8 Compare November 12, 2024 19:04
@Repiteo Repiteo merged commit 8c0e1a7 into godotengine:master Nov 13, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 13, 2024

Thanks!

@Chaosus Chaosus deleted the vs_copy_paste_preview_material branch November 13, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants