Warn if XRHandModifier3D used with OpenXR and hand-tracking disabled #96587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
approved these changes
Sep 5, 2024
dsnopek
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
It's not ideal having something OpenXR-specific in XRHandModifier3D which is meant to be general to any XR interface, however, I think this is an important enough warning that it's worth doing. (And it's checking if OpenXR is enabled first, so it shouldn't confuse folks using only WebXR.)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With hand-tracking switching from default-enabled to default-disabled in Godot 4.4+ it's common for older projects to have broken hand-tracking. To help with this issue, this PR adds a warning to XRHandModifier3D nodes if OpenXR is enabled, but the OpenXR hand-tracking extension is disabled.