-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] Fix building with deprecated=no
#96570
[C#] Fix building with deprecated=no
#96570
Conversation
deprecated=no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. I'm not too familiar with C# buildsystem stuff though so I'll let @raulsntos double check.
107aad7
to
2c55a23
Compare
I don't see any merge commits ;) |
2c55a23
to
aed2209
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, but we'd want to disable the entire Compat.cs
and also do the same in the GodotSharpEditor
assembly.
aed2209
to
e9762b3
Compare
Makes sense to me. I also considered excluding Compat.cs first, but wasn't sure, if there was stuff in it which is still needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Thanks! And congrats for your first merged Godot contribution 🎉 |
This fixes GH-84426.
I added the option
--no-deprecated
tobuild_assemblies.py
, which needs to be used, if the editor was built withdeprecated=no module_mono_enabled=yes
.This conditionally disables code in
Compat.cs
which references deprecated classes or functions.