Fix Inspector may scroll away when editing a property that adds or removes sub properties #96542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maran23
force-pushed
the
inspector-scrolls-away
branch
from
a208a71 to
266c099
Compare
…emoves sub properties
Maran23
force-pushed
the
inspector-scrolls-away
branch
from
266c099 to
27b7b43
Compare
KoBeWi
approved these changes
Sep 28, 2024
akien-mga
changed the title
akien-mga
added
the
cherrypick:4.3
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #96489
The fix done in #92108 was not enough to elimate the scrolling issue completely.
This PR fixes the problem by doing two things:
EditorInspectors have theirfollow_focusset to false, as they do not have a vertical scroll bar (SCROLL_MODE_DISABLED) and that property is handled by the root (=main)EditorInspectoranywayfollow_focusis only changed for the rootEditorInspector, that is the top Inspector that contains all the subEditorInspectors (and that may contain again subEditorInspectors)To do this, I utilized the already existing sub inspector flag and refactored it to a reference to the root inspector instead.
unknown_2024.09.04-00.36.mp4
Also removed an obsolete TODO that exists since 6 years and makes no sense (that the filter is enabled is correct, so that the search bar works)