GDExtension: Allow class names to be unicode #96501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
scgm0
force-pushed
the
Allow-class-names-to-be-unicode
branch
from
9d3bb88 to
f46353d
Compare
scgm0
force-pushed
the
Allow-class-names-to-be-unicode
branch
from
f46353d to
3badff1
Compare
dsnopek
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Thanks!
I'm really surprised that this was all that's required on the Godot side. In order to test it, I needed to make some changes to godot-cpp (see PR godotengine/godot-cpp#1574). But with that, it worked fine in my testing!
|
Thanks! |
|
Nice, now we can use emojis in our class names 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to use Chinese class names in my personal projects as they are hard to translate.