-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Transform2D/3D in lerp()
#96496
Conversation
The supported types are listed in the description so that should be updated as well. |
@lyuma @TokageItLab Transform2D and Transform3D lerps are not really lerps anymore since it's a composite of lerp position, lerp scale and slerp rotation, but from a usability point of view I have nothing blocking it. 👍 |
c9b6067
to
c592757
Compare
Well, lerp of Vector3 is also a composite of lerp of 3 floats and slerp is a different story altogether so I think transform interpolation goes well in to the mix... I now changed the description as well. Also fixed a small factual error in the description (instead of clamping the output, |
c592757
to
edefc2a
Compare
edefc2a
to
7218dd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your arguments to add Transform2d and Transforms3d makes sense for usability.
lerp()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
Thanks! |
Implements godotengine/godot-proposals#10579