Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Advanced Settings switch to Editor Settings #96467

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 2, 2024

Closes #30866

godot.windows.editor.dev.x86_64_oXfACy2LJL.mp4

Feel free to suggest changes to this list.

Other than that:

  • restore_scenes_on_load is no longer marked as requiring restart
  • enabled code that makes default value settings not stored

@KoBeWi KoBeWi added this to the 4.x milestone Sep 2, 2024
@KoBeWi KoBeWi marked this pull request as draft September 2, 2024 12:06
@Maran23
Copy link
Contributor

Maran23 commented Sep 2, 2024

Some suggestions for basic settings:
[Editor]

  • Language
  • Dock Tab Style
  • Font Size
  • Display Scale
  • Single Window Mode

[Theme]

  • Follow System Theme
  • Preset
  • Spacing Preset

[Connection]

  • Engine Version Update Mode
  • Network Mode

[Import]

  • Blender Path

[Complection]

  • Idle Parse Delay
  • Code Complete Delay
  • Add String Name Literals
  • Add Node Path Literals

[Window Placement] (also in case Godot does allow to run the game in the editor)

[Linuxbsd]

  • Prefer Wayland

[Project Manager] (the three settings)

[Android]

  • Android SDK Path
  • Java SDK Path

[macOS]

  • rcodesign

[Windows]

  • rcedit
  • signtool

@Mickeon
Copy link
Contributor

Mickeon commented Sep 2, 2024

Are you by chance implementing this button partially because of #69012 (review) ?

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 2, 2024

No, but I can look into integrating that. Maybe after both PRs are merged.

@KoBeWi KoBeWi force-pushed the finally_we_can_add_editor_setting_for_everything_because_it_will_be_hidden_behind_advanced_toggle_anyway_lol branch from 78ac6c5 to 137e285 Compare September 2, 2024 17:24
@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 2, 2024

Ok finished.

I noticed editor settings are annoyingly hackish. Customized settings are defined via a set of macros and some of them manually specify restart usage. I'll probably do a follow-up to make it closer to project settings. And then maybe unify the 2 somehow, because there is duplicated code.

Check OP for current settings overview and changes summary.

@KoBeWi KoBeWi marked this pull request as ready for review September 2, 2024 17:25
@KoBeWi KoBeWi requested review from a team as code owners September 2, 2024 17:25
editor/editor_settings.cpp Outdated Show resolved Hide resolved
platform/android/export/export.cpp Outdated Show resolved Hide resolved
@KoBeWi KoBeWi force-pushed the finally_we_can_add_editor_setting_for_everything_because_it_will_be_hidden_behind_advanced_toggle_anyway_lol branch from 137e285 to 5545dd7 Compare September 2, 2024 19:25
@KoBeWi KoBeWi requested a review from m4gr3d September 2, 2024 19:25
@KoBeWi KoBeWi force-pushed the finally_we_can_add_editor_setting_for_everything_because_it_will_be_hidden_behind_advanced_toggle_anyway_lol branch from 5545dd7 to 54c7bda Compare September 2, 2024 19:46
@m4gr3d m4gr3d modified the milestones: 4.x, 4.4 Sep 5, 2024
@KoBeWi KoBeWi force-pushed the finally_we_can_add_editor_setting_for_everything_because_it_will_be_hidden_behind_advanced_toggle_anyway_lol branch from 54c7bda to c0a394e Compare September 5, 2024 13:43
@KoBeWi KoBeWi force-pushed the finally_we_can_add_editor_setting_for_everything_because_it_will_be_hidden_behind_advanced_toggle_anyway_lol branch from c0a394e to 97ea1f1 Compare September 5, 2024 16:57
@akien-mga
Copy link
Member

Needs rebase, then looks good to merge IMO.

@KoBeWi KoBeWi force-pushed the finally_we_can_add_editor_setting_for_everything_because_it_will_be_hidden_behind_advanced_toggle_anyway_lol branch from 97ea1f1 to 4023ace Compare September 17, 2024 10:21
@akien-mga akien-mga merged commit 7da3f81 into godotengine:master Sep 17, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the finally_we_can_add_editor_setting_for_everything_because_it_will_be_hidden_behind_advanced_toggle_anyway_lol branch September 17, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced Settings option
7 participants