Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Polygon2D UV editor error when opening grid settings #96411

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

larspet
Copy link
Contributor

@larspet larspet commented Aug 31, 2024

Fixes #96187

The grid settings window now gets added as a child to the UV editor window, instead of as a sibling. In addition to the error going away, you can no longer close the UV editor window while keeping the grid settings up.

@larspet larspet requested a review from a team as a code owner August 31, 2024 21:31
@AThousandShips AThousandShips added this to the 4.4 milestone Sep 1, 2024
Copy link
Member

@kleonc kleonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@kleonc kleonc added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Sep 1, 2024
@kleonc
Copy link
Member

kleonc commented Sep 1, 2024

Marked for cherry-picking as reproducible in there as well. In v4.1.4.stable.official [fe0e8e5] the error is slightly different though ("Transient parent has another exclusive child.").

@akien-mga akien-mga merged commit 1474bd7 into godotengine:master Sep 2, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@larspet larspet deleted the uv-editor-error branch September 2, 2024 13:33
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:editor topic:2d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with Polygon2D-Editor
5 participants