CI: Add C compile step for gdextension_interface.h
#96408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Looks good to me! But it would be good for folks who are more engaged with the build/CI stuff to advise if this is a good place to put it in the GitHub workflows.
The CI failed before PR #96406 was merged in the expected way. I've just clicked the button for that job to re-run, so we can ensure it passes now that that has been fixed.
UPDATE: Ah, nevermind, it'll need to be rebased before it'll actually pass.
akien-mga
changed the title
gdextension_interface.hgdextension_interface.h
It has happened repeatedly that C++ code accidentally crept into the GDExtension C header, a notable example being use of the `bool` type. This change adds a CI step to check the header with a C-only compiler.
Bromeon
force-pushed
the
feature/gdextension-c-compile
branch
from
6ab1b8c to
c89a57d
Compare
|
Rebased on master. |
akien-mga
approved these changes
Sep 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has happened repeatedly that C++ code accidentally crept into the GDExtension C header, a notable example being use of the
booltype, latest example being #96406.This change adds a CI step to check the header with a C-only compiler. I chose gcc without any flags, let me know if there's an invocation that would fit better.
Also, I put it as a separate job next to Godot CPP; maybe there's a better place.
This CI will fail until #96406 is merged.