Fix no unsaved indicator Save As resource #96363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
cherrypick:4.3
KoBeWi
reviewed
Aug 31, 2024
KoBeWi
reviewed
Aug 31, 2024
KoBeWi
approved these changes
Aug 31, 2024
Hilderin
force-pushed
the
fix-no-unsaved-indicator-save-as-resource
branch
from
d5865c0 to
b97c128
Compare
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no unsaved indicator on the scene after using "Save As..." on an internal resource. That caused the issue where the user did not get a warning if he closed the scene after doing the "Save As..." option.
I added a connect to the
resource_savedsignal on the EditorNode to know when the resource was saved. The signal is only disconnected when theEditorResourcePickerexit the tree. I don't think it's possible that theresource_savedsignal could be emitted for theedited_resourceonEditorResourcePickeron which the "Save As..." was used without it to be removed from the tree.