Deprecate set_min_buttons_width_from_icons
#96276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
deprecated_on_arrival
branch
from
00ade48 to
a7b7b1b
Compare
KoBeWi
force-pushed
the
deprecated_on_arrival
branch
from
a7b7b1b to
5d7dfc6
Compare
|
|
#96555 is merged, please rebase the branch, it should works now. |
KoBeWi
force-pushed
the
deprecated_on_arrival
branch
from
5d7dfc6 to
bde64c4
Compare
Mickeon
approved these changes
Sep 5, 2024
akien-mga
approved these changes
Sep 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #89265 (comment), the new
set_min_buttons_width_from_iconsis redundant and only added for compatibility with existing themes. This PR deprecates it and makesicon_widthbehave likeset_min_buttons_width_from_iconswhen the value is less than 0.Although seems like theme items don't support deprecated messages .-.
To remove
set_min_buttons_width_from_iconsin the future, we'll need to adjust SpinBox icons to have proper width.