Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Change breakpoint shortcuts to avoid conflicts #96179

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

passivestar
Copy link
Contributor

@passivestar passivestar commented Aug 27, 2024

Fixes this issue:

#23548 (comment)

Changes:

  • Go To Previous Breakpoint: Command+Comma -> Control+Comma
  • Go To Next Breakpoint: Command+Period -> Control+Period

Making Command+Comma work reliably for Settings is important because it's the standard shortcut to open them in all macOS apps. Using Ctrl for the breakpoint shortcuts seems like the best option because that's how these kinds of cross-platform conflicts are usually handled (i.e in Godot Ctrl+R is used to restart particle emission)

Edit: Also added a comment like in #93581 explaining that not using Command on mac is intentional

@passivestar passivestar requested a review from a team as a code owner August 27, 2024 18:51
@passivestar
Copy link
Contributor Author

Turns out Command+Period is also taken by default (Stop Running Project), so this PR solves 2 conflicts, not 1

ED_SHORTCUT_OVERRIDE("editor/stop_running_project", "macos", KeyModifierMask::META | Key::PERIOD);

@passivestar passivestar changed the title [macOS] Change breakpoint shortcuts to avoid conflict with the settings shortcut [macOS] Change breakpoint shortcuts to avoid conflicts Aug 31, 2024
@akien-mga akien-mga merged commit 69888aa into godotengine:master Sep 3, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@passivestar passivestar deleted the mac-breakpoint-shortcuts branch September 3, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants