Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadzone slider not working correctly #96000

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

kerstop
Copy link
Contributor

@kerstop kerstop commented Aug 23, 2024

closes #95223

@kerstop kerstop requested a review from a team as a code owner August 23, 2024 17:48
@AThousandShips AThousandShips added this to the 4.4 milestone Aug 23, 2024
@AThousandShips AThousandShips added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 23, 2024
@fire fire changed the title fix deadzone slider not working correctly Fix deadzone slider not working correctly Aug 25, 2024
Copy link
Contributor

@anniryynanen anniryynanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reproduced the bug in v4.4.dev1.official [28a72fa] and confirm that this PR fixes it. As far as I can tell, the code changes look good.

@akien-mga akien-mga merged commit 168676a into godotengine:master Sep 3, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:editor topic:gui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadzone slider not working in input map menu
5 participants