Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure fog_sky_affect is used even when using a background color #95659

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

clayjohn
Copy link
Member

Fixes: #95591

#91642 accidentally changed the logic to only use fog_sky_affect if both volumetric and distance fog were in use. This just brings back the original logic.

This is a regression from the middle of the 4.3 release cycle. So the fix should be included in both 4.4 and 4.3.1

@clayjohn clayjohn requested a review from a team as a code owner August 16, 2024 21:13
@clayjohn clayjohn added bug topic:rendering regression cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 16, 2024
@clayjohn clayjohn added this to the 4.4 milestone Aug 16, 2024
@clayjohn clayjohn requested a review from BastiaanOlij August 16, 2024 21:13
@akien-mga akien-mga changed the title Ensure fog_sky_affect is used even when using a background color Ensure fog_sky_affect is used even when using a background color Aug 16, 2024
@akien-mga akien-mga merged commit 5b6d9a7 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment fog does not affect sky, even with "Sky Affect" set to 1 (Vulkan)
3 participants