Fix Godot not quitting with --doctool --gdscript-docs.
#95656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:gdscript
cherrypick:4.3
|
The commit message got mangled (likely Unix shell interpreting |
anvilfolk
force-pushed
the
gdscript-docs-quit
branch
from
bbe499b to
13b2082
Compare
Thanks for the heads up! Should be fixed! |
akien-mga
approved these changes
Aug 16, 2024
|
Thanks! |
|
Thank you, glad to be back <3 |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#82116 moved GDScript doctool code to after Autoloads were loaded. However, to get there,
Main::start()also selects a main loop, and thus starts running and does not quit. This PR fixes the issue by forcing Godot to quit after 1 main loop iteration.It feels a lot easier than untangling the exact dependencies (and no more, e.g. Autoloads, which use ResourceLoader and may
preloadlots of different things, etc) that are needed to generate docs and then refactoringMain::start()order to have GDScript doctool happen at the exact "right time". It also feels better than adding GDScript-specific code that deletes previously created main loops!