-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate timeline snapping control to Animation Editor #95638
Add separate timeline snapping control to Animation Editor #95638
Conversation
It's feedback, but the icons and descriptions are unclear. Although I think it's fine for the function :) With SnapTimeline and SnapKey, there is a misconception that it snaps to the grid of the timeline and the keys of other tracks (like smart grid); we need to avoid confusing it with such as the "grid snap" and "point snap" in Draw software / DCC software. So more thought needs to be given to icons. It may be exaggerated to use Enum and explain it in text, but at least the description should be something like "Apply snapping to current time/key", not "Snap Timeline". |
@TokageItLab yeah good point. I'll improve the description. I quite like your icons idea... I'll fire up Inkscape and see what I can do! |
31aee28
to
ff40b3a
Compare
Redesigned the icons and improved the descriptions and renamed a few things. CquxyPfm4s.mp4I'm not sure if that timeline snap icon reads well. it kind of looks like a taller version of the filter icon with a magnet next to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tooltip explanation needs some consideration, but I see that the icons and the behavior are fine.
ff40b3a
to
25c3717
Compare
@akien-mga rebased and conflict resolved |
25c3717
to
88a866f
Compare
Sorry @TokageItLab , forgot to update that as I had to do a few and thought it was just the merge conflict on this one. Should be updated now as suggested. |
Thanks! |
This adds a separate toggle for timeline snapping (disabled by default as per @Calinou 's suggestion in the proposal)
Closes godotengine/godot-proposals#10225
godot.windows.editor.dev.x86_64_fFM33ZjKip.mp4
Both can still be toggled by holding Ctrl/Command
Note I changed the
_get_editor_step()
function to no longer check for whether snapping was enabled as it was already done before the function call in the_seek_value_changed
function. Then I added a check the_animation_key_editor_seek
function as well.