Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glTF capitalization in error messages #95603

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

tetrapod00
Copy link
Contributor

@tetrapod00 tetrapod00 commented Aug 16, 2024

Follow-up to #95578. See also godotengine/godot-docs#9750.

I looked through the glTF module for user-visible errors use "GLTF", and replaced usages of "GLTF" with "glTF".
If an error message was changed in a file, I replaced "GLTF" with "glTF" in comments of the same file.
If a .cpp file was changed, I also changed comments in the associated header file.

There are still some usages of "GLTF" in comments in other files, but they are no longer user-visible.

@tetrapod00 tetrapod00 requested a review from a team as a code owner August 16, 2024 01:12
@Chaosus Chaosus added this to the 4.4 milestone Aug 16, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I confirmed that none of these strings are localized (TTR), so this won't break translations.

@akien-mga akien-mga merged commit ec74e14 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@tetrapod00 tetrapod00 deleted the gltf-capitalization-errors branch August 16, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants