Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET] Move search in files extension list definition to be after Scene level module init. #95502

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 13, 2024

Follow up to #94680

It is too early to check for CSharpScript in the project settings, since it's loaded only as Scene level module.

Might fix #95496 (it the only issue is missing filter, I can't reproduce any other issues with search).

@bruvzg bruvzg added this to the 4.4 milestone Aug 13, 2024
@bruvzg bruvzg requested a review from a team as a code owner August 13, 2024 21:05
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 13, 2024
@bruvzg bruvzg requested a review from a team as a code owner August 13, 2024 21:16
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is related to #94680 since I can reproduce the missing .cs filter in v4.2.2.stable.mono.official [15073af]. But I can confirm this PR fixes the issue.

@akien-mga akien-mga merged commit 1d4303c into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find in Files doesn't search in .cs files out of the box in Mono build
3 participants