Add template images to the Cubemap class documentation #95396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds an example sky shader for using a cubemap as a skybox. This solution should be preferred to converting the cubemap texture to a panorama sky, as that method implies a loss in quality compared to the source cubemap.
Calinou
added
enhancement
documentation
cherrypick:4.3
mhilbrunner
approved these changes
Oct 30, 2024
|
Thanks! |
Spartan322
reviewed
Jan 16, 2025
Comment on lines
+10
to
+13
| - [url=https://raw.githubusercontent.com/godotengine/godot-docs/master/img/cubemap_template_2x3.webp]2×3 cubemap template (default layout option)[/url] | ||
| - [url=https://raw.githubusercontent.com/godotengine/godot-docs/master/img/cubemap_template_3x2.webp]3×2 cubemap template[/url] | ||
| - [url=https://raw.githubusercontent.com/godotengine/godot-docs/master/img/cubemap_template_1x6.webp]1×6 cubemap template[/url] | ||
| - [url=https://raw.githubusercontent.com/godotengine/godot-docs/master/img/cubemap_template_6x1.webp]6×1 cubemap template[/url] |
There was a problem hiding this comment.
The url should be https://raw.githubusercontent.com/godotengine/godot-docs/master/tutorials/assets_pipeline/img/xxx.webp
There was a problem hiding this comment.
Pull request opened:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds an example sky shader for using a cubemap as a skybox. This solution should be preferred to converting the cubemap texture to a panorama sky, as that method implies a loss in quality compared to the source cubemap.