Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of EditorImportPlugin._Import #95335

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

esainane
Copy link
Contributor

@esainane esainane commented Aug 9, 2024

The following is the currently generated EditorImportPlugin.cs:

    public virtual Error _Import(string sourceFile, string savePath, Dictionary options, Array<string> platformVariants, Array<string> genFiles)
    {
        return Error.Ok;
    }

This fixes the type signature in the documentation's example to match the actual type signature.

The following is the currently generated `EditorImportPlugin.cs`:

```csharp
    public virtual Error _Import(string sourceFile, string savePath, Dictionary options, Array<string> platformVariants, Array<string> genFiles)
    {
        return Error.Ok;
    }
```

This fixes the type signature in the documentation's example to match the
actual type signature.
@esainane esainane requested a review from a team as a code owner August 9, 2024 16:10
@AThousandShips AThousandShips requested a review from a team August 9, 2024 16:14
@AThousandShips AThousandShips added bug documentation cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 9, 2024
@AThousandShips AThousandShips added this to the 4.4 milestone Aug 9, 2024
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 9, 2024
@akien-mga akien-mga modified the milestones: 4.4, 4.3 Aug 9, 2024
@akien-mga akien-mga merged commit 1d7b318 into godotengine:master Aug 12, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contributions 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants