[MP] Avoid error spam in relay protocol when clients disconnect #95192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple clients are connected, and the server is using the relay sub-protocol, it might happen that a client disconnects while a packet sent to it from another peer is still in transit. In that case, when the packet reaches the server for relaying, it used to generate an error (as the destination client did no longer exists). This commit changes check to suppress the error message while still skipping the packet.
Faless
added
bug
topic:multiplayer
cherrypick:4.1
akien-mga
approved these changes
Aug 6, 2024
|
Thanks! |
|
Thank you for your efforts; my logs will be much cleaner now. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple clients are connected, and the server is using the relay sub-protocol, it might happen that a client disconnects while a packet sent to it from another peer is still in transit.
In that case, when the packet reaches the server for relaying, it used to generate an error (as the destination client did no longer exists).
This commit changes check to suppress the error message while still skipping the packet.
Fixes #70505