Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid saving EditorSettings on startup #95171

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Aug 5, 2024

Similar to #89248
EditorSettings were saved when launching, because of dialog update.

@KoBeWi KoBeWi added this to the 4.4 milestone Aug 5, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner August 5, 2024 19:15
@akien-mga akien-mga merged commit 01b87a9 into godotengine:master Aug 16, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@AeioMuch
Copy link
Contributor

This seems to make the Editor Settings take a while to close for me, is it normal ?

@KoBeWi KoBeWi deleted the remove_save branch August 17, 2024 07:49
@KoBeWi
Copy link
Member Author

KoBeWi commented Aug 17, 2024

Are you sure this PR is what caused it?
It's not expected, but slow was already a problem before.

@AeioMuch
Copy link
Contributor

AeioMuch commented Aug 17, 2024

Are you sure this PR is what caused it? It's not expected, but slow was already a problem before.

I tried to do a checkout of the commit just before this one got merged, and the slowdown disappeared. Then checkout the merge of this one or everything after and the slowdown is back.

Before, closing the window by pressing the X button is instant, after it takes ~7seconds (on debug build). The editor also freeze for a bit after the editor settings window is not visible anymore.

The slowdown disappeared and got fixed for good by pressing the Close button instead of the X button of the window itself. Removing the editor_settings-4.4.tres will make the issue come back.

@KoBeWi
Copy link
Member Author

KoBeWi commented Aug 17, 2024

Open a new issue with a minimal project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants