Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LightmapGI causes crash when using --headless #95103

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

jamie-pate
Copy link
Contributor

Fixes #89119

Add dummy LightmapInstance and Lightmap resources for headless rendering

Prevents the RenderingServer from crashing when it accesses lightmap_instance->base_data

@jamie-pate jamie-pate requested a review from a team as a code owner August 3, 2024 17:50
@jamie-pate jamie-pate force-pushed the fix_89119 branch 2 times, most recently from b647124 to 1921494 Compare August 3, 2024 17:56
@Calinou Calinou added bug topic:rendering crash topic:3d cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 3, 2024
@Calinou Calinou added this to the 4.4 milestone Aug 3, 2024
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@akien-mga akien-mga modified the milestones: 4.4, 4.3 Aug 7, 2024
@akien-mga akien-mga added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release and removed cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 7, 2024
Fixes godotengine#89119

Add dummy LightmapInstance and Lightmap resources for headless rendering

Prevents the RenderingServer from crashing when it accesses
lightmap_instance->base_data
@akien-mga akien-mga merged commit 031b71f into godotengine:master Aug 7, 2024
17 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga changed the title Fix LightmapGI causes crash when using --headless Fix LightmapGI causes crash when using --headless Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release crash topic:rendering topic:3d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightmapGI causes crash when using --headless
5 participants