Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in EditorPlugin _forward_3d_draw_over_viewport(overlay) method example #94997

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

erictuvesson
Copy link
Contributor

The example is now matching the C# example

Too few arguments for "draw_circle()" call. Expected at least 3 but received 2.

…thod example

Too few arguments for "draw_circle()" call. Expected at least 3 but received 2.
@erictuvesson erictuvesson requested a review from a team as a code owner July 31, 2024 22:12
@akien-mga akien-mga added this to the 4.3 milestone Jul 31, 2024
@akien-mga akien-mga added cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels Jul 31, 2024
@akien-mga akien-mga merged commit 0e244fc into godotengine:master Aug 6, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@erictuvesson
Copy link
Contributor Author

Thanks! And congrats for your first merged Godot contribution 🎉

Thanks for all the great work! I have done a few merged PR's previously 😄

@erictuvesson erictuvesson deleted the fix/typo branch August 6, 2024 11:42
@akien-mga
Copy link
Member

akien-mga commented Aug 6, 2024

Thanks! And congrats for your first merged Godot contribution 🎉

Thanks for all the great work! I have done a few merged PR's previously 😄

Seems like you renamed your GitHub account, so I missed the previous ones when checking by handle in the git log ;)

Welcome back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants