Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Load optional ninja tool before setting its options #94993

Merged

Conversation

akien-mga
Copy link
Member

SCons 4.8.0 made this stricter, as we were advised in #94805.
Thanks @mwichmann for the headsup.

SCons 4.8.0 made this stricter, as we were advised in godotengine#94805.

Fixes godotengine#94805.
@akien-mga akien-mga added this to the 4.3 milestone Jul 31, 2024
@akien-mga akien-mga requested a review from a team as a code owner July 31, 2024 21:05
@akien-mga akien-mga merged commit e503566 into godotengine:master Jul 31, 2024
18 checks passed
@akien-mga akien-mga deleted the scons-4.8.0-load-ninja-earlier branch July 31, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to load ninja tool before issuing ninja-related SetOption
1 participant