C#: Generate signal delegates with typed arrays #94953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out we were generating the C# signal delegates without using the type generic parameters. This means for a signal with a parameter of type
TypedArray<StringName>
we were using typeArray
. The signal delegate generation now matches the method generation more closely.Changing this would normally break compatibility, luckily there's only one signal in Godot that uses a generic type (
GraphEdit::delete_nodes_request
) andGraphEdit
is marked experimental.Also took the opportunity to remove an unused String in the C# bindings generator:
delegate_type_params
.