Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for folding "Editable Children" nodes in Scene tree not being saved #94911

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

yahkr
Copy link
Contributor

@yahkr yahkr commented Jul 29, 2024

closes #91542

When _fill_folds is called on a child of an instantiated scene with editable children enabled, it will not be parsed correctly on child nodes due to the is_editable_instance check never being true.

Changed:

if (p_node->get_owner() != p_root && !p_root->is_editable_instance(p_node)) {
if (p_node->get_owner() != p_root && !p_root->is_editable_instance(p_node->get_owner())) {

MRP Taken from related issue
Node.Folding.zip

@akien-mga akien-mga requested a review from KoBeWi July 29, 2024 12:38
@akien-mga akien-mga added this to the 4.x milestone Jul 29, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Aug 19, 2024
@akien-mga akien-mga merged commit 3241b44 into godotengine:master Aug 19, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@yahkr yahkr deleted the 91542-fix branch December 4, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants