Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use-after-free in WorkerThreadPool #94832

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix use-after-free in WorkerThreadPool #94832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/object/worker_thread_pool.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ void WorkerThreadPool::_process_task(Task *p_task) {
}
#endif

#ifdef THREADS_ENABLED
bool low_priority = p_task->low_priority;
alvinhochun marked this conversation as resolved.
Show resolved Hide resolved
#endif

if (p_task->group) {
// Handling a group
bool do_post = false;
Expand Down Expand Up @@ -159,7 +163,7 @@ void WorkerThreadPool::_process_task(Task *p_task) {
#ifdef THREADS_ENABLED
{
curr_thread.current_task = prev_task;
if (p_task->low_priority) {
if (low_priority) {
low_priority_threads_used--;

if (_try_promote_low_priority_task()) {
Expand Down
Loading