Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GraphEdit] Correctly disconnect signal to connection_layer #94810

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[GraphEdit] Correctly disconnect signal to connection_layer #94810

merged 1 commit into from
Jul 30, 2024

Conversation

maidopi-usagi
Copy link
Contributor

@maidopi-usagi maidopi-usagi commented Jul 26, 2024 •
edited
Loading

Fix #94811

@maidopi-usagi maidopi-usagi requested a review from a team as a code owner July 26, 2024 17:35
@AThousandShips AThousandShips added this to the 4.4 milestone Jul 26, 2024
@AThousandShips AThousandShips added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jul 26, 2024
@AThousandShips AThousandShips modified the milestones: 4.4, 4.3 Jul 26, 2024
@AThousandShips AThousandShips requested a review from Geometror July 26, 2024 17:48
@akien-mga akien-mga changed the title [GraphEdit] Correctly disconnect signal to connection_layer [GraphEdit] Correctly disconnect signal to connection_layer Jul 29, 2024
@akien-mga akien-mga merged commit 5271a39 into godotengine:master Jul 30, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Geometror Geometror Geometror approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

[GraphEdit] GraphElement's 'item_rect_changed' signal is not disconnected when leaving tree
4 participants
@maidopi-usagi @akien-mga @Geometror @AThousandShips