[Web] Fix closure compiler builds, enable it in CI. #94789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offending symbol gets stripped away by wasm-dce but it's used on the JavaScript side and causes and undefined symbol which also causes the closure compiler to throw an error.
akien-mga
approved these changes
Jul 26, 2024
Also fixes some JSDoc annotations in GodotAudio
Faless
force-pushed
the
web/fix_thread_cc_with_workaround
branch
from
2747177 to
96feb92
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
-sMAIN_MODULE=2with-pthreadmisses exports__emscripten_thread_crashedand__embind_initialize_bindingsemscripten-core/emscripten#21844 (comment)Adds
__emscripten_thread_crashedtoEXPORTED_FUNCTIONS(which also required adding_mainto prevent it from being stripped as dead code as described here).This is not needed for dlink builds which uses
-sEXPORT_ALL=1.Also fixes some JSDoc annotations in GodotAudio.
Fixes #94725