Fix scene node selection problem when no auto expand #94773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
cherrypick:4.2
KoBeWi
reviewed
Aug 17, 2024
KoBeWi
approved these changes
Aug 17, 2024
Hilderin
force-pushed
the
fix-add-child-node-problem-no-auto-expand
branch
from
75072b9 to
e46280d
Compare
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the option
Docks > Scene Tree > Auto Expand to Selectedwas disabled, theselectednode was not updated in the methodSceneTreeEditor::set_selected. Additionally, even if the node was not collapsed,tree->ensure_cursor_is_visiblewas never called, preventing the user from seeing the node after its creation if the tree was long enough. The same problem was present when navigating with the back/forward buttons of the Inspector.Problem reproduction:
godot.windows.editor.dev.x86_64_gdbCU4VPiT.mp4
godot.windows.editor.dev.x86_64_6iS9OR0YIH.mp4