Fix total weight calculation to separate track types #94716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
fix-total-weight
branch
from
8c06f7e to
04ac6a7
Compare
akien-mga
approved these changes
Jul 25, 2024
TokageItLab
force-pushed
the
fix-total-weight
branch
from
04ac6a7 to
f3cf4f5
Compare
akien-mga
added a commit
that referenced
this pull request
Jul 25, 2024
Fix total weight calculation to separate track types
|
Welp, I merged this PR locally just before you pushed a new commit, and now pushed it to So it's 04ac6a7 that got merged, if more changes are needed this will need to be in another PR. |
|
Oops, sorry |
|
No problem, I actually noticed the yellow "CI running" icon just after pushing to |
|
@akien-mga Alright I sent #94722, I should have checked carefully too, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The total weight was added to normalize the blend amount in non-deterministic blending by #80813.
Before #86687, checking by blend idx was sufficient due to track type conflicts, since it was not working due to a bug in the first place. Now that the type is managed as a hash for each cache type, it should be changed to a check by that.
Explanation of their differences: