Remove linearization of canvas modulate in GLES3 backend #94707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GLES3 renderer is always in sRGB space, even when using an HDR format
akien-mga
approved these changes
Jul 24, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to: #93802
I was unclear in my review comment and requested that some new changed be reverted. I meant that only the changes to the RD backend should be reverted, but I was unclear in my message. Previous changes to the GLES3 backend were also reverted and then merged when they should not have been.
The GLES3 renderer is always in sRGB space, even when using an HDR format, so we should never linearize the inputs