[C#] Change the VisualShaderNodeCustom template to use the correct override types and signatures
#94693
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/mono/editor/script_templates/VisualShaderNodeCustom/basic.cs
Outdated
Show resolved
Hide resolved
modules/mono/editor/script_templates/VisualShaderNodeCustom/basic.cs
Outdated
Show resolved
Hide resolved
modules/mono/editor/script_templates/VisualShaderNodeCustom/basic.cs
Outdated
Show resolved
Hide resolved
modules/mono/editor/script_templates/VisualShaderNodeCustom/basic.cs
Outdated
Show resolved
Hide resolved
AThousandShips
changed the title
VisualShaderNodeCustom template to use the correct override types and signatures
raulsntos
approved these changes
Aug 11, 2024
There was a problem hiding this comment.
Looks good to me, thanks!
You'll need to squash the commits before this PR can be merged. The contributing documentation contains information about squashing in case you need it.
Feel free to reach out in the development chat if you need help.
Chaosus
added
the
cherrypick:4.3
…rides and added the GlobalClass attribute
|
I've squashed the commits into one now, it should be good to go! @raulsntos |
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to create a custom VisualShader Node, it wouldn't show up any of the custom nodes when implemented in C# (works with GDScript), trying to create one from within the editor using the provided template created a script with compile errors.
I saw somwhere in the source that we should assume 64-bit types, so that might be why long is used instead of int, but since it's a signature / type mismatch with the base class, it won't compile.
I also added the Godot.Tool attribute, since it is required according to the docs:
"... you must use the
@toolannotation ..."https://docs.godotengine.org/en/4.2/classes/class_visualshadernodecustom.html#description
I will also submit an issue for the problem related to the C# VisualShaderNodeCustom files not showing up / getting recognized by the editor.
(This is my first PR, so I might have missed something!)