Bind PhysicsServer*D::body_set_state_sync_callback
#94653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Looks good.
You can also update the docs for the GDExtension equivalent:
diff --git a/doc/classes/PhysicsServer2DExtension.xml b/doc/classes/PhysicsServer2DExtension.xml
index 41826ea7c2..07c65915c6 100644
--- a/doc/classes/PhysicsServer2DExtension.xml
+++ b/doc/classes/PhysicsServer2DExtension.xml
@@ -713,7 +713,7 @@
<param index="1" name="callable" type="Callable" />
<description>
Assigns the [param body] to call the given [param callable] during the synchronization phase of the loop, before [method _step] is called. See also [method _sync].
- Overridable version of [PhysicsServer2D]'s internal [code]body_set_state_sync_callback[/code] method.
+ Overridable version of [method PhysicsServer2D.body_set_state_sync_callback].
</description>
</method>
<method name="_body_test_motion" qualifiers="virtual const">(there's no docs for PhysicsServer3DExtension yet)
rburing
approved these changes
Jul 23, 2024
mihe
force-pushed
the
bind-physics-state-sync
branch
from
b917da6 to
a559a1c
Compare
|
@akien-mga Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you want to implement your own
RigidBody*D-like physics nodes from the script side of things, whether that's GDScript, C#, C++, Rust or any other scripting language, you're forced to hack the state synchronization (i.e. pulling the latest state from the physics server) by using the callback passed tobody_set_force_integration_callback, which can sort of serve the same purpose as the callback passed tobody_set_state_sync_callback.This is a hack though, and
body_set_state_sync_callbackshould rightfully be exposed/bound, so this PR does exactly that.