Fix header_guards.py so it detects the copyright header properly.
#94652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having hardcoded offsets is a problem if the copyright header ever changes or when running on forks with different copyright header formats.
AThousandShips
added
enhancement
topic:buildsystem
cherrypick:4.2
AThousandShips
added
cherrypick:4.1
akien-mga
changed the title
header_guards.py so it detects the copyright header properly.
Repiteo
approved these changes
Jul 23, 2024
akien-mga
added
bug
and removed
enhancement
cherrypick:4.1
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having hardcoded offsets is a problem if the copyright header ever changes or when running on forks with different copyright header formats. This looks for the Godot header and determines the offset based on it, or if there's no header, at the start of the file. The obj-c detection had to be tweaked, as there are dummy files that only have commented out code.
Contributed with ❤️ by W4Games