Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when assigning more textures than expected to texture array #94628

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix crash when assigning more textures than expected to texture array #94628

merged 1 commit into from
Jul 23, 2024

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jul 22, 2024

@Chaosus Chaosus requested a review from a team as a code owner July 22, 2024 16:18
@Chaosus Chaosus added this to the 4.3 milestone Jul 22, 2024
@Chaosus Chaosus force-pushed the rendering_fix_crash branch from a583597 to 746509d Compare July 22, 2024 16:54
AThousandShips
AThousandShips approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@Chaosus Chaosus force-pushed the rendering_fix_crash branch from 746509d to 574e61a Compare July 22, 2024 17:51
@akien-mga akien-mga merged commit ad1955a into godotengine:master Jul 23, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the rendering_fix_crash branch July 23, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug crash topic:rendering
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

memory overflow when shader's uniform array out of range
4 participants
@Chaosus @akien-mga @clayjohn @AThousandShips