GLES3: Fix directional shadow on Metal ANGLE #94556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
the
cherrypick:4.2
akien-mga
changed the title
clayjohn
approved these changes
Jul 22, 2024
akien-mga
force-pushed
the
fix-directional-shadow
branch
from
2b1ae50 to
fa8b4d8
Compare
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #93537 and closes #94515 .
When using
textureProjwithsampler2DShadow, there is a bug in ANGLE on MacOS browsers(https://issues.angleproject.org/issues/354101888), causing directional shadows to not work. This issue is resolved by replacing textureProj with textureProjLod, which functions correctly.UPDATE: It was marked as fixed in Chromium 130.0.6697.0.
Test
MRP scene:
Before (shadow seems inverted):
After:
Complex Scene:
Before (directional shadow seems disappear):
After:
There appears to be no performance impact.
Export Packages For Test
textureProj.zip
textureProjLOD.zip
Tested on MacOS Safari/Chrome/Firefox