Few fixes for VisualShaderNodeRotationByAxis
#94497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Chaosus
commented
Jul 18, 2024
•
Chaosus
commented
- Fixed preview port for the input
- Added a default value for the first port to prevent error when it's not connected
- Fixed description to be more detailed
- Allow use it in other shader modes (no need to restrict it)
- Since it returns two outputs, then it makes sense to generates a code only when they are connected to other nodes.
akien-mga
approved these changes
Jul 18, 2024
Chaosus
force-pushed
the
vs_rotation_by_axis
branch
2 times, most recently
from
c78601e to
7a02730
Compare
Chaosus
force-pushed
the
vs_rotation_by_axis
branch
from
7a02730 to
cf70cb5
Compare
paddy-exe
approved these changes
Jul 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.