[C#] Allow using the Signal attribute on events #94440
Open
+149
−77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current method to declare a signal in a C# class requires declaring an inner delegate type. This prevents polymorphism using interfaces since unrelated classes cannot declare a signal of the same type.
Closes #80033, closes godotengine/godot-proposals#9373
Usage
This PR enables using the
Signal
attribute on events of existing delegate types (such asAction
):Emitting the signal is still done using
EmitSignal(SignalName.MySignal)
, but now the event can be declared in an interface.Potential Drawbacks
Invoke
method on signals declared using an event, which shouldn't be used.